[stm32, aes, cryp, pka] Zeroize AES registers after performing operation and on cleanup#48
Merged
Merged
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #48
Scan targets checked: wolfhal-bugs, wolfhal-src
No new issues found in the changed files. ✅
aidangarske
reviewed
Jun 22, 2026
aidangarske
left a comment
aidangarske
left a comment
Member
There was a problem hiding this comment.
Skoll Multi-Scan Review
Modes: review + review-securityOverall recommendation: COMMENT
Findings: 4 total — 1 posted, 3 skipped
1 finding(s) posted as inline comments (see file-level comments below)
Posted findings
- [Medium] [review+review-security] N6 driver skips ZeroKeyIv on key-setup/init/header error paths (inconsistent with WB driver and the PR's stated goal) —
src/crypto/stm32n6_cryp.c:405-408,417-419,508-511,522-524,623-625,798-806,1079-1087,1217-1226,1256-1258
Skipped findings
- [Low]
Stack buffers holding key-derived/tag material are not zeroed before return - [Low]
No test exercises the new register-zeroization behavior - [Info]
ECB/CBC/CTR streaming (Start/Process) sessions retain key in registers until Deinit
Review generated by Skoll
aidangarske
reviewed
Jun 22, 2026
…on and on cleanup
AlexLanzano
force-pushed
the
fenrir-fixes
branch
from
48e3f24 to
34c3e5c
Compare
aidangarske
approved these changes
Jun 22, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #48
Scan targets checked: wolfhal-bugs, wolfhal-src
No new issues found in the changed files. ✅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.