Skip to content

modify version bounds for dependencies#129

Open
sebastian-carpenter wants to merge 1 commit into
wolfSSL:masterfrom
sebastian-carpenter:no-max-dep-version
Open

modify version bounds for dependencies#129
sebastian-carpenter wants to merge 1 commit into
wolfSSL:masterfrom
sebastian-carpenter:no-max-dep-version

Conversation

@sebastian-carpenter

Copy link
Copy Markdown
Contributor

ZD#22033:
Removed maximum version bound for dependencies

Also noticed that the minimum cffi version is not consistent so I synchronized it to 1.17. This is the minimum for python 3.13.

  • This may cause issues for Python 3.10 which has a minimum of 1.15

@sebastian-carpenter sebastian-carpenter self-assigned this Jun 24, 2026
Copilot AI review requested due to automatic review settings June 24, 2026 17:49

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates dependency constraints across packaging metadata and requirements files to remove upper version bounds, and standardizes the minimum cffi version to 1.17 (notably needed for Python 3.13 support).

Changes:

  • Removed maximum version caps from runtime/test/docs requirements.
  • Raised and synchronized the minimum cffi version to >=1.17 across setup.py, pyproject.toml, and requirements/prod.txt.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
setup.py Updates setup_requires / install_requires to require cffi>=1.17.
pyproject.toml Updates project dependency on cffi to >=1.17.
requirements/prod.txt Updates runtime cffi requirement to >=1.17 without an upper bound.
requirements/test.txt Removes upper bounds for tox, pytest, and types-cffi.
requirements/docs.txt Removes upper bounds for Sphinx and the RTD theme dependency.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread pyproject.toml
Comment thread requirements/docs.txt Outdated
 * Remove bound for maximum version
 * Synchronize minimum version for cffi to 1.17
@mjdemilliano

Copy link
Copy Markdown
Contributor

"This may cause issues for Python 3.10 which has a minimum of 1.15" => it's the other way around: according to the cffi release notes, version 1.15 adds Python 3.10 support. In version 2.0.0 support is dropped for Python 3.8.

This change works for me, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants