modify version bounds for dependencies#129
Open
sebastian-carpenter wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Updates dependency constraints across packaging metadata and requirements files to remove upper version bounds, and standardizes the minimum cffi version to 1.17 (notably needed for Python 3.13 support).
Changes:
- Removed maximum version caps from runtime/test/docs requirements.
- Raised and synchronized the minimum
cffiversion to>=1.17acrosssetup.py,pyproject.toml, andrequirements/prod.txt.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.py | Updates setup_requires / install_requires to require cffi>=1.17. |
| pyproject.toml | Updates project dependency on cffi to >=1.17. |
| requirements/prod.txt | Updates runtime cffi requirement to >=1.17 without an upper bound. |
| requirements/test.txt | Removes upper bounds for tox, pytest, and types-cffi. |
| requirements/docs.txt | Removes upper bounds for Sphinx and the RTD theme dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Remove bound for maximum version * Synchronize minimum version for cffi to 1.17
3331826 to
dbb21f3
Compare
Contributor
|
"This may cause issues for Python 3.10 which has a minimum of 1.15" => it's the other way around: according to the cffi release notes, version 1.15 adds Python 3.10 support. In version 2.0.0 support is dropped for Python 3.8. This change works for me, thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ZD#22033:
Removed maximum version bound for dependencies
Also noticed that the minimum cffi version is not consistent so I synchronized it to 1.17. This is the minimum for python 3.13.