SFTP Timestamp incorrect for FATFS

[J-Goldacker]

wolfssh/src/wolfsftp.c

Lines 4958 to 4959 in 6e69959

	atr->atime = info.ftime;
	atr->mtime = info.ftime;

The problem is here. FATFS time info has it's own format. The solution for NUCLEUS (function TimeTo32(d, t)) looks very similar. Maybe it is the same, but I could not test it yet.

SFTP_GetAttributes_Handle seems to have the same problem.

[embhorn]

Hi @J-Goldacker

Thanks for contacting wolfSSL Support. Could you tell us a bit about your project using wolfSSH? I've requested a review of this issue by our engineers.

Kind regards,
@embhorn - wolfSSL Support

[ejohnstown]

Does the RTOS you are running on have the function mktime()?

[ejohnstown]

I have a fix posted as a PR. I haven't tested the date conversion yet. That's why the PR is a draft. Please let me know if that works for you.

[J-Goldacker]

Hi @ejohnstown, thank you very much. I've left two comments in your PR.

Yes, we have mktime.

I'll try the changes on the target and give you feedback.

Edit: I've ran the code. With the change from my comment (add 80 to the year) it works
#define WS_GETYEAR(d) ((((d) >> 9) & 0x007f) + 80)

[ejohnstown]

I have updated the PR. Thank you for the feedback.

[ejohnstown]

PR #977 is merged. Thanks!

[J-Goldacker]

Thank you for solving this so quickly.