Skip to content

SFTP client sanity check on version used by the server #1133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejohnstown merged 1 commit into from
Jul 29, 2026
Merged

SFTP client sanity check on version used by the server #1133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/wolfsftp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6374,6 +6374,16 @@ static int SFTP_ClientRecvInit(WOLFSSH* ssh) {
}

ato32(buf + LENGTH_SZ + MSG_ID_SZ, &version);
/* The server is supposed to reply with the lower of its own and
* our version, so a value above ours is a non-conforming server. In
* that case we continue on with the same v3 version. If the server
* replies with a version before v3 then return early here since
* there will be SSH_FXP_STATUS incompatibility issues. */
if (version < WOLFSSH_SFTP_VERSION) {
WLOG(WS_LOG_SFTP, "Unsupported SFTP version from server");
return WS_VERSION_E;
}

sz = sz - MSG_ID_SZ - UINT32_SZ;
ssh->sftpExtSz = sz;
ssh->sftpState = SFTP_EXT;
Expand Down
Loading