Skip to content

tests: derive the expected ECC rejection in the priv-only key test #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JacobBarthelmeh merged 1 commit into from
Aug 21, 2026
Merged

tests: derive the expected ECC rejection in the priv-only key test #1187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions tests/unit.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11167,6 +11167,7 @@ static int test_IdentifyAsn1Key_EccPrivOnlyDerFailure(int curveSz,
byte* eccDer = NULL;
int eccDerSz;
int i;
int expected = WS_CRYPTO_FAILED;

WMEMSET(&eccKey, 0, sizeof(eccKey));
if (wc_ecc_init(&eccKey) != 0) {
Expand Down Expand Up @@ -11209,12 +11210,30 @@ static int test_IdentifyAsn1Key_EccPrivOnlyDerFailure(int curveSz,
}
}

/* Some wolfSSL builds reject the zeroed scalar while decoding the DER,
* so IdentifyAsn1Key never reaches the derivation and reports the key
* as unidentified. Ask this build which rejection to expect. */
{
ecc_key probeKey;
word32 probeIdx = 0;

if (wc_ecc_init(&probeKey) != 0) {
WFREE(eccDer, NULL, 0);
return -6939;
}
if (wc_EccPrivateKeyDecode(eccDer, &probeIdx, &probeKey,
(word32)eccDerSz) != 0) {
expected = WS_UNIMPLEMENTED_E;
}
wc_ecc_free(&probeKey);
}

ret = IdentifyAsn1Key(eccDer, (word32)eccDerSz, 1, NULL, NULL);
WFREE(eccDer, NULL, 0);

if (ret != WS_CRYPTO_FAILED) {
printf("IdentifyAsn1Key: private-only ECC %s DER fallback derivation "
"expected WS_CRYPTO_FAILED, got %d\n", curveName, ret);
if (ret != expected) {
printf("IdentifyAsn1Key: private-only ECC %s DER rejection expected "
"%d, got %d\n", curveName, expected, ret);
return -6938;
}

Expand Down
Loading