Conversation
With 44, 65 and 87 all off, keygen and key loading still took ML-DSA.
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1289
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 3 in-scope changed file(s) opened by the reviewer; not opened: src/internal.c
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Crypto feature gating and its CI configurations warrant final human verification.
Review effort: Balanced
Findings: None
What changed in this PR
This PR makes wolfSSH disable ML-DSA when all three ML-DSA levels are disabled, with checks for the resulting configuration.
Changes:
- Derives
WOLFSSH_NO_MLDSAfrom the three level-disable macros. - Adds a unit check and CI configurations for disabled levels.
- Guards ML-DSA-44 test data and updates the feature documentation.
| File | Description |
|---|---|
wolfssh/internal.h |
Derives the all-levels-disabled macro. |
tests/unit.c |
Checks disabled-level behavior and guards ML-DSA-44 test data. |
src/internal.c |
Documents the derived macro. |
.github/workflows/mldsa-composite-config.yml |
Adds CI configurations and output checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defined WOLFSSH_NO_MLDSA when all three level macros are set. Added test_MlDsaLevelsDisabled to ensure keygen runs WS_NOT_COMPILED when all levels are off, and wraped ML-DSA-44 keys in macro checks. Exercised no-mldsa44 and no-levels in CI.