F-1289 F-1718 F-1707 oob write and null pointer fixes#579
Conversation
stenslae
commented
Jun 25, 2026
- F-1718 and F-1701: Out-of-bounds array write with negative index from failed wolfSSL_read
- F-1289: Wrong variable checked after wolfSSL_new()
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #579
Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src
Findings: 2
1 finding(s) posted as inline comments (see file-level comments below)
Low (1)
Server wolfSSL_new() result still checks wrong variable
File: tls/memory-tls.c:188
Function: main
Category: NULL pointer dereference
The F-1289 fix corrected the client check to cli_ssl, but the identical server-side instance in main() still tests srv_ctx == NULL instead of srv_ssl, so a failed wolfSSL_new(srv_ctx) goes undetected and a NULL srv_ssl is passed to wolfSSL_accept.
Recommendation: Change the check to if (srv_ssl == NULL).
Referenced code: tls/memory-tls.c:188-189 (2 lines)
This review was generated automatically by Fenrir. Findings are non-blocking.
a4ea301 to
2318302
Compare
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #579
Scan targets checked: wolfssl-examples-bugs, wolfssl-examples-src
No new issues found in the changed files. ✅