Skip to content

Fix: WolfCrypt Fenrir - 6145, 5384, 4432, 5392#10786

Draft
aidankeefe2022 wants to merge 1 commit into
wolfSSL:masterfrom
aidankeefe2022:fenrir-fixes-jun24/26-ak
Draft

Fix: WolfCrypt Fenrir - 6145, 5384, 4432, 5392#10786
aidankeefe2022 wants to merge 1 commit into
wolfSSL:masterfrom
aidankeefe2022:fenrir-fixes-jun24/26-ak

Conversation

@aidankeefe2022

Copy link
Copy Markdown
Member

Description

https://fenrir.wolfssl.com/finding/6145 -

wc_DsaVerify/wc_DsaVerify_ex leave *answer uninitialized on all error paths, unlike sibling ECC/ECCSI verify APIs that default to "not verified"

  • Initialized value for answer parameter to zero so on early exit the out parameter is defined to false.

https://fenrir.wolfssl.com/finding/5384 -

CAAM secure-memory addresses are truncated to 32 bits in ECC keys

  • Changed the ecc_key fields to be CAAM_ADDRESS if it is defined this will allow for expansion with platform so addresses are not truncated.

https://fenrir.wolfssl.com/finding/4432 -

wc_DrbgState_MutexInit Unsafe Lazy Mutex Initialization Without WOLFSSL_MUTEX_INITIALIZER

  • Instead of check on plain int we use atomic operations if they are present to init the mutex. This means no two threads can init the same mutex.

https://fenrir.wolfssl.com/finding/5392 -

DES key schedule branches on secret key bits

  • instead of if statement we use a mask to set bits in ks.

https://fenrir.wolfssl.com/finding/5384

https://fenrir.wolfssl.com/finding/4432

https://fenrir.wolfssl.com/finding/5392

https://fenrir.wolfssl.com/finding/5392

skoll fixes

Changed type for keys for CAAM in ecc so it matches assignment with out cast to never truncate

Added check to see if CAAM_ADDRESS is defined before using in ecc.h
@aidankeefe2022 aidankeefe2022 self-assigned this Jun 25, 2026
@aidankeefe2022 aidankeefe2022 changed the title https://fenrir.wolfssl.com/finding/6145 Fix: WolfCrypt Fenrir - 6145, 5384, 4432, 5392 Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant