Add ML-DSA coverage to the wolfCrypt crypto callback test - #11611
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new pre-hash callback paths are not exercised or independently asserted.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds ML-DSA routing validation to wolfCrypt’s crypto callback tests.
Changes:
- Implements ML-DSA keygen, signing, and verification callback paths.
- Adds callback hit counters and PQ configuration coverage.
| File | Description |
|---|---|
wolfcrypt/test/test.c |
Adds ML-DSA callback handling and assertions. |
.github/configs/pq-all.json |
Adds three ML-DSA callback configurations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
dgarske
force-pushed
the
mldsa_cryptocb
branch
2 times, most recently
from
September 30, 2026 23:54
29864b4 to
26431dc
Compare
dgarske
force-pushed
the
mldsa_cryptocb
branch
from
October 1, 2026 17:38
26431dc to
6604522
Compare
anhu
approved these changes
Oct 1, 2026
anhu
previously approved these changes
Oct 1, 2026
dgarske
force-pushed
the
mldsa_cryptocb
branch
from
October 2, 2026 00:35
6604522 to
8251f34
Compare
philljj
requested changes
Oct 2, 2026
philljj
left a comment
Contributor
There was a problem hiding this comment.
merge conflict in test.c
dgarske
force-pushed
the
mldsa_cryptocb
branch
from
October 2, 2026 16:44
8251f34 to
b2f9d8b
Compare
Contributor
|
jenkins retest this please |
dgarske
force-pushed
the
mldsa_cryptocb
branch
from
October 3, 2026 01:38
b2f9d8b to
f04673a
Compare
philljj
approved these changes
Oct 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
myCryptoDevCbsupports SLH-DSA and Falcon (WC_PK_TYPE_PQC_SIG_*) but lacked ML-DSA handling. Becausemldsa_test()runs undercryptocb_test()using callback key devIds, ML-DSA operations previously fell back to software without verifying callback execution.Key Changes:
wolfcrypt/test/test.c: AddedWC_PQC_SIG_TYPE_MLDSAcallback handling for keygen, pure/pre-hash signing, and verification, complete with post-test hit counter assertions..github/configs/pq-all.json: Added cryptocb configurations (verify-only,yes,draft,sign,verify).SIG_VERIFY_Eerror returns matchingwc_MlDsaKey_VerifyCtx()behavior.Note: Software fallback remains for
WOLFSSL_MLDSA_NO_CTXdue to context ambiguity.Testing
Validated using
testwolfcryptacross multiple build configurations:no-ctx,draft,verify-only,make,sign,verify, single-level, andswdevvariants.make checkpassed with--enable-all --enable-experimental --enable-all-quantum-crypto --enable-cryptocb --enable-cryptocbutils.-pedantic,-Wconversion,-Wsign-conversion,-Wcast-qual) with ML-DSA, SLH-DSA, and Falcon enabled concurrently.