Add crypto callback for wc_falcon_check_key - #11640
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
padelsbach
force-pushed
the
falcon-cb-check-key
branch
from
October 3, 2026 03:57
0f64053 to
800b2b8
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new test fails in supported Falcon level-5-only builds, and the public API documentation remains outdated.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds Falcon private-key validation support to the crypto callback framework.
Changes:
- Dispatches
wc_falcon_check_key()through the Falcon crypto callback. - Adds callback behavior and fallback tests.
- Updates internal return-value documentation.
| File | Description |
|---|---|
wolfcrypt/src/falcon.c |
Adds Falcon key-check callback dispatch. |
wolfcrypt/test/test.c |
Adds callback-path and error-handling tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| * PUBLIC_KEY_E when either half is not set, or when the stored public | ||
| * key h does not satisfy the defining relation h = g/f (mod q) for the | ||
| * private (f, g), | ||
| * private (f, g), the crypto callback result for a device backed key, |
Contributor
Author
|
jenkins retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously,
wc_falcon_check_key()did not dispatch to the crypto callback. This sends the check to the callback asWC_PK_TYPE_PQC_SIG_CHECK_PRIV_KEYwithWC_PQC_SIG_TYPE_FALCON, matching `wc_SlhDsaKey_CheckKey()Testing
added unit tests
Checklist