style: remove import group comments and separators - #751
Merged
Merged
Conversation
Gutenberg dropped the dependency group comments and blank lines between imports; align with its ESLint configuration. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Vitest hoists `vi.mock` calls, so the import need not follow them. Keeping imports contiguous prevents the import/order fixer from collapsing the blank lines around the mocks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Generated by `make lint-web-fix` under the new import rules, plus one manual blank-line removal the fixer could not apply. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
github-actions
Bot
added
the
[Type] Task
XCFramework BuildThis PR's XCFramework is available for testing. Add the following to your .package(url: "https://github.com/wordpress-mobile/GutenbergKit", branch: "pr-build/751")Built from 8d286eb |
dcalhoun
marked this pull request as ready for review
October 1, 2026 14:44
jkmassel
added a commit
that referenced
this pull request
Oct 2, 2026
…dia-upload-middleware Conflicts: - src/utils/api-fetch.js: keep core's `apiFetch.mediaUploadMiddleware` and the renamed `stripDraftPostIdMiddleware` from this branch, and register trunk's `mediaPermissionsMiddleware` after them, as it was on trunk. - src/utils/api-fetch.test.js: keep both sides' `apiPathModifierMiddleware` tests and trunk's `mediaPermissionsMiddleware` tests. Also applies trunk's lint rules to two files that only exist on this branch: drops the import group comments from api-fetch-post-process.test.js (#751) and adds a blank line Prettier now requires in local-wordpress.md (#722).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Remove import group comments.
Why?
Align with upstream Gutenberg core latest practices in WordPress/gutenberg#81188 and WordPress/gutenberg#81248.
How?
Testing Instructions
N/A, no user-facing changes.
Accessibility Testing Instructions
N/A, no user-facing changes.
Screenshots or screencast
N/A, no user-facing changes.
AI-generated details
Aligns with Gutenberg's removal of import group comments (#81188, #81248): imports are now one contiguous block, with no
/** External | WordPress | Internal dependencies */comments or blank lines.eslint.config.jsenables@wordpress/dependency-group: neverandimport/order(newlines-between: never), matching Gutenberg's config. Neither is in@wordpress/eslint-plugin's recommended config.make lint-web-fixoutput. The fixer also moved three relative imports below package imports (src/utils/editor.jsxand two hook tests); stylesheet load order is unaffected.make lint-web-fixafter rebasing..git-blame-ignore-revs.Verified with
make lint-webandmake test-web-unit(276 passing).🤖 Generated with Claude Code