CMM-2301: Always show the Me row when the bottom nav is hidden - #23213
Open
nbradbury wants to merge 6 commits into
Open
CMM-2301: Always show the Me row when the bottom nav is hidden#23213nbradbury wants to merge 6 commits into
nbradbury wants to merge 6 commits into
Conversation
The Me row in My Site exists to replace the bottom navigation's Me tab when that nav is hidden, but it was gated on site capabilities instead. Both flags it checked are permanently false for sites added over the application-password / WP-API path: hasCapabilityManageOptions is only populated from the WP.com REST response, and isSelfHostedAdmin only from XML-RPC wp.getUsersBlogs. Such users had no route to Me at all, and so no Account Settings, App Settings, Experimental Features or Help & Support. Gate the row on exactly the condition WPMainActivity uses to hide the nav. Me is account-level, so site capabilities play no part. This also drops the duplicate row that appeared for self-hosted admins while the nav was still visible, which b4450f8 already intended to remove. MeFragment now gates its toolbar on the host activity rather than the removal phase, so it can't render a title-less, back-button-less screen.
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## trunk #23213 +/- ##
=======================================
Coverage 37.90% 37.90%
=======================================
Files 2347 2347
Lines 127732 127728 -4
Branches 17767 17763 -4
=======================================
+ Hits 48411 48419 +8
+ Misses 75355 75343 -12
Partials 3966 3966 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Document why buildMeItemIfAvailable needs no explicit Jetpack app check: getCurrentPhase() returns null there, so shouldRemoveJetpackFeatures() is always false. The dependency was invisible at the call site once the explicit guard was removed. Resolve the MeActivity host once instead of calling requireActivity() twice with a redundant cast, which leaves the AppCompatActivity import unused. Drop the release notes entry so this PR doesn't touch the file.
Compress the KDoc paragraph on the implicit Jetpack app exclusion, drop a test comment that described a scenario the test can't exercise now that buildMeItemIfAvailable takes no site, and move the Me tests out of the pages group so they sit after the site settings tests, matching the order of the builder's own methods.
An unqualified [shouldRemoveJetpackFeatures] doesn't resolve from SiteListItemBuilder — the method belongs to JetpackFeatureRemovalPhaseHelper, and importing the class doesn't bring its members into scope.
nbradbury
marked this pull request as ready for review
August 13, 2026 15:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes CMM-2301.
In the WordPress app, signing in to a self-hosted site with an application password could leave the user with no route to the Me screen at all — no Account Settings, App Settings, Experimental Features or Help & Support. The bottom nav is hidden by design once Jetpack features are removed, and the My Site "Me" row that replaces it was never added.
Testing instructions
Me is reachable on WPAndroid with the nav hidden:
Jetpack app regression:
Before and after shot