Repository navigation
Run independent deployment steps in parallel - #1156
Conversation
- build: upload the version and manifest while the Phar is built. - test: start MySQL and download the Phar in the background while PHP and Composer are set up. - deploy: download the three artifacts in parallel. - build-rpm/build-deb: install apt tooling in the background while the repositories are checked out and the Phar is downloaded. Also sync the actionlint ignores for the new step keywords from wp-cli/.github. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XKUgMbWCUXHvDzgDBPWcZA
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe deployment workflow now runs selected artifact operations and package-tool installations in parallel with other preparation steps. It waits for background tasks before dependent work. Actionlint ignores diagnostics for the workflow’s parallel-step syntax. ChangesWorkflow parallelization
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Refactor Sequence Diagram(s)sequenceDiagram
participant FunctionalTestJob
participant MySQLSetup
participant PharArtifactDownload
participant PharPreparation
FunctionalTestJob->>MySQLSetup: start setup in background
FunctionalTestJob->>PharArtifactDownload: start download in background
FunctionalTestJob->>FunctionalTestJob: wait for both background steps
FunctionalTestJob->>PharPreparation: prepare the Phar
Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change runs independent deployment steps in parallel to speed up the workflow. No concrete defect was found. The workflow is not exercised by this PR's CI, so the first run after merge, or a manual dispatch, will confirm it. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🧪 Generate unit tests (beta)
🛠️ Fix failing CI checks 💡
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This failure doesn't come from this PR:
GitHub can only re-run failed jobs once the whole run has finished, so I'll re-run this job once at that point to confirm. Generated by Claude Code |
Uses the new parallel step keywords in
deployment.yml:parallelgroup with the Phar build.wait-allbefore the Phar is moved into place.parallelgroup.apt-gettooling install runs in the background while the repositories are checked out and the Phar is downloaded;wait-allbefore the package build.The two checkouts in the rpm/deb jobs stay sequential, as the root checkout could clean the
bundle/one.Also updates
.github/actionlint.ymlto match wp-cli/.github (it is synced from there), since actionlint does not know the new keywords yet.Note:
deployment.ymlonly runs on pushes tomain/release-**and manual dispatch, so this PR's CI won't exercise it; it will be verified on the first run after merge (or viaworkflow_dispatchon this branch).🤖 Generated with Claude Code
https://claude.ai/code/session_01XKUgMbWCUXHvDzgDBPWcZA
Generated by Claude Code
Summary by CodeRabbit