Skip to content

feat(workshop): add canonical min/max variable modifiers - #99

Merged
Teakowa merged 1 commit into
mainfrom
feat/issue-95-pr
Aug 24, 2026
Merged

feat(workshop): add canonical min/max variable modifiers#99
Teakowa merged 1 commit into
mainfrom
feat/issue-95-pr

Conversation

@Teakowa

@Teakowa Teakowa commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add canonical ModifyOp::Min and ModifyOp::Max identities and catalog linkage
  • parse and emit global, player, and indexed variable modification forms, including min= and max=
  • reject unsupported named assignment operators explicitly
  • add parser, WIR, catalog, locale round-trip, and oracle-contract coverage

Verification

  • cargo fmt --all -- --check
  • cargo run --locked -p workshop-rs --bin workshop-catalog-gen -- check
  • cargo test --locked --workspace --all-targets --no-fail-fast
  • cargo clippy --locked --workspace --all-targets -- -D warnings

OverPy and Workshop.codes define Max/Min as variable modification operations. Live-client execution is outside this PR.

Fixes #95

@Teakowa
Teakowa merged commit 85d0db5 into main Aug 24, 2026
3 checks passed
@Teakowa
Teakowa deleted the feat/issue-95-pr branch August 24, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add canonical min/max variable modification operations

1 participant