Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe logs UI removes pod filtering. Filter types, facet derivation, matching logic, toolbar controls, view state, messages, and tests now support project-only client-side filtering. ChangesLogs filter contract and matching logic
Logs view integration
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Other Merge Risk: ⚪ Minimal · up to The logs console now supports project-only client-side narrowing as intended, with no concrete unresolved merge risk identified. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Description checkExplanation The description explains the purpose, implementation, affected files, and verification results. However, it omits most required template sections, including User stories, Documentation, Security checks, Samples, Related PRs, and Test environment details. Resolution Complete the required template sections. Add explicit User stories, Documentation status, Security checks, Samples, Related PRs, and Test environment details. Include the required Purpose, Goals, Approach, and Automation tests headings or clearly map the existing content to those sections.
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3472 +/- ##
==========================================
- Coverage 53.91% 53.02% -0.90%
==========================================
Files 219 798 +579
Lines 44881 127479 +82598
Branches 0 4447 +4447
==========================================
+ Hits 24199 67593 +43394
- Misses 18870 53414 +34544
- Partials 1812 6472 +4660
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
2 participants
Follow-up to #3430. Removes the Pod select from the Logs toolbar; Project stays.
A pod name is a gateway name plus a replicaset hash plus a scheduler suffix, so the select was a list of strings nobody recognises, and the two pods of one gateway sit next to each other under names that differ only in the tail. Project already separates the lines a reader actually wants apart, and the source column still shows the pod when a line carries no component name — so nothing becomes unfindable.
What changed
LogsToolbar.tsxFormControlandpodOptionsare gone; picking a project no longer has to clear a pod; the caption says "Project narrows the lines already on screen"types.tsLogViewFilters.pod,LogFacets.podsandLogFacets.podsByProjectremovedconsoleLines.tsderiveFacetsno longer collects pods or groups them by project;matchesViewdrops the pod clauseLogsFeature.tsxINITIAL_VIEWlosespod; the "N of M loaded lines match" note names one filterconsoleLines.test.tsLogEntry.podNameis kept —toConsoleLinestill falls back to it for the source column.No backend change: the pod filter ran entirely in the browser, and
GET /logsnever took apodNameparameter.Verification
tsc --noEmitclean under both host configs (tsconfig.jsonagainst ai-workspace's deps,tsconfig.console.jsonagainst api-control-plane's).🤖 Generated with Claude Code