Fix motion scanner for second player, synchronize motion-scanned enemy positions, and allow ALT soldier direction/motion scan viewing for off-turn player#8
Open
NonPolynomialTim wants to merge 1 commit into
Conversation
…o-op ALT-held facing-direction arrows (and motion-scanner markers) were suppressed for the off-turn player: the per-unit draw in Map.cpp forced the ALT/CTRL modifier state to false whenever it was not the local player's turn. These are read-only observer visuals, so allow them during the off-turn view too. Add a "motion_scan" TCP packet so that when one player's motion scanner detects a unit, the other player's map shows the same marker. The scanned-turn flag was UI-only and never networked; the packet carries the unit id and the scanning turn so vanilla marker semantics hold. Fix motion points not syncing to the second player in a co-op turn: the "PlayerTurnYour" and "current_seed" receivers read motionpoints from the top-level JSON object instead of the per-unit element, so every unit was set to 0 motion points on turn handover, leaving the second player's motion scanner blind to enemies that moved. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ALT-held facing-direction arrows (and motion-scanner markers) were suppressed for the off-turn player: the per-unit draw in Map.cpp forced the ALT/CTRL modifier state to false whenever it was not the local player's turn. These are read-only observer visuals, so allow them during the off-turn view too.
Add a "motion_scan" TCP packet so that when one player's motion scanner detects a unit, the other player's map shows the same marker.
Fix motion points not syncing to the second player in a co-op turn: the "PlayerTurnYour" and "current_seed" receivers read motionpoints from the top-level JSON object instead of the per-unit element, so every unit was set to 0 motion points on turn handover, leaving the second player's motion scanner blind to enemies that moved.