Repository navigation
Enable ASLR and DEP for Windows DLLs (#288, #661) - #742
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #288 and #661. The bundled
snappyjava.dllfiles are currently linked without ASLR/DEP opt-in:objdump -pon the x86_64 DLL showsDllCharacteristics 00000000. This PR adds these linker flags inMakefile.common:-Wl,--dynamicbase -Wl,--nxcompat-Wl,--high-entropy-vaThe Build Native workflow gets a new step that fails if the built x86 or x86_64 DLL is missing
DYNAMIC_BASE/NX_COMPAT(andHIGH_ENTROPY_VAon 64-bit).SafeSEH, also reported in #661, isn't supported by the MinGW linker, so it isn't covered here.
After merge, the Build Native workflow on
mainwill open an "Update native libraries" PR with the rebuilt DLLs.Test plan
🤖 Generated with Claude Code