Clean up deck sources and guard them against comments - #772
Merged
Conversation
Coverage report
This PR does not seem to contain any modification to coverable code. |
Remove the slide-end comment blocks from slides.md. Delivery notes live in the private talks repository now, so the copy published here carries only what renders on screen, matching how the APS deck already ships. Nothing rendered changed: 117 deletions and no insertions, with the slide count 20 before and after and the frontmatter untouched. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Slidev compiles comments in slides.md into the deck's JavaScript bundle, so a comment written there ships with the deck rather than staying in the source. Nothing checked for them: the docs workflow builds whatever talks/<slug>/ it finds, and the architecture hook is scoped to Python files. The check enumerates git-tracked talks/*/slides.md, so it ranges over every deck rather than only the one being changed, and it asserts that a deck was found at all so an empty match cannot report green over nothing. Verified by reintroducing a comment block and confirming the failure before removing it. A pre-commit hook runs it on deck edits, which the Python-scoped hooks would miss; CI has no path filters, so it runs there on every pull request too. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
xmap
force-pushed
the
worktree-strip-maxiv-notes
branch
from
September 4, 2026 18:29
6059fbb to
9f917c5
Compare
xmap
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits, both about keeping published deck sources to what renders on
screen.
Clean up the MAX IV deck source. Removes the slide-end comment blocks from
slides.md. Delivery notes live in the private talks repository now, so thepublished copy matches how the APS deck already ships. Nothing rendered
changed: 117 deletions and no insertions, slide count 20 before and after,
frontmatter untouched.
Guard published deck sources against HTML comments. Slidev compiles
comments in
slides.mdinto the deck's JavaScript bundle, so a comment writtenthere ships with the deck. Nothing checked for this before: the docs workflow
builds whatever
talks/<slug>/it finds, and the architecture hook is scoped toPython.
The check enumerates git-tracked
talks/*/slides.md, so it ranges over everydeck rather than only the one being changed, and it asserts that a deck was
found at all so an empty match cannot report green over nothing. Verified by
reintroducing a comment block and confirming the failure before removing it
again.
A pre-commit hook runs it on deck edits, which the Python-scoped hooks would
miss. CI has no path filters, so it runs there on every pull request too.
🤖 Generated with Claude Code