Host aliases sits three tabs away from the switch that gates it - #119
Merged
Conversation
Move the field from Experts only to Spider, under URL hacks. The engine folds a www. alias only when that checkbox is on (hts_host_alias_collapse_www is urlhack && !no_www_dedup), and both other front ends already keep the field beside it: WinHTTrack on IDD_OPTION8, WebHTTrack on option8.html. guide.html documents it in the opt-spider section, so Help from the tab now opens a page that mentions the field. A tab looks its @fields ids up in its own inflated layout and WidgetDataExchange throws on a view it cannot find, so a test checks every tab's declared ids against that tab's layout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Check the other direction too: a view the mapper knows but no tab claims is never saved, and nothing at runtime says so. A tab whose annotations the pattern cannot read used to yield no ids and pass; it now fails. The layout walk gets a second user, so it moves to TestSources. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
xroche
added a commit
that referenced
this pull request
Aug 13, 2026
* release: bump to 3.50-beta-5 (versionCode 93) Engine pin unchanged at 3.49.21. The only change since beta-4 is the Host aliases field moving to the Spider tab (#119), so the release notes keep beta-4's items and only bump the version word across the 29 locales. Open testing is still on vc91 and has never seen those items. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com> * Keep the beta-4 name: only the versionCode moves Open testing serves vc91, so this build is still beta 4 for the users who will see it; beta-4's release notes stand unchanged. Play only requires the versionCode to increase, and the versionName may repeat. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com> --------- Signed-off-by: Xavier Roche <roche@httrack.com> Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine folds a
www.alias only when URL hacks is on (hts_host_alias_collapse_wwwisurlhack && !no_www_dedup), and URL hacks is a Spider option, so Host aliases moves there from Experts only. WinHTTrack puts the field on its Spider pane next toIDC_urlhack, WebHTTrack renders it onoption8.html, andguide.htmldocuments it inside theopt-spidersection, so the tab's Help link now lands on a page that describes the field. Emission is untouched:fieldsSerializerstill fixes the argv order and the profile key is the same, so saved projects keep working.A field left in the wrong tab's list crashes that tab when you leave it. The new test reads each tab's ids out of
OptionsActivity.javaand checks them against that tab's layout; leaving the id in the Experts list fails it.