The default HTML footer teaches %s, which breaks any field a user adds - #121
Merged
Conversation
The default -%F template used the positional %s%s ... %s form, and one %s
anywhere in the string puts the whole template on the engine's legacy
positional path. Append {mime} to it and the braces reach every saved page
verbatim.
Named fields have been the documented model since xroche/httrack#667 and
the pinned engine already substitutes them, so nothing here needs a
submodule bump. Existing projects keep the footer they saved; only new
projects pick up the new default. The hint under the field showed the same
positional form, so it moves too, and a test keeps the two from drifting
apart.
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Xavier Roche <roche@httrack.com>
The two existing assertions pass on any string carrying {url} and {date},
so a default that lost the HTTrack attribution or the comment markers went
unnoticed while the hint tracked it.
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The default
-%Ftemplate used the positional%s%s ... %sform, and one%sanywhere in the string puts the whole template on the engine's legacy positional path. Append{mime}to it and the braces reach every saved page verbatim.Named fields have been the documented model since xroche/httrack#667 and the pinned engine already substitutes them, so nothing here needs a submodule bump. Existing projects keep the footer they saved; only new projects pick up the new default. The hint under the field showed the same positional form, so it moves too, and a test keeps the two from drifting apart.
One visible difference:
{url}carries the scheme, which the old pair could not, because the engine strips it from the host before substituting positionally. New mirrors readMirrored from http://example.com/a/b.htmlwhere they used to readMirrored from example.com/a/b.html. Host, path and date are unchanged.