Android writes a pause key the other front ends do not read - #134
Merged
Conversation
Android wrote Pause for the -%G random inter-file pause; WinHTTrack and WebHTTrack both write PauseFiles, so a profile carrying one was silently missing the setting for the other two. Take the majority spelling and read the old one through the existing rename shim. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
The key tables are parallel: a stored field and the option mapper that turns it into an engine argument. Renaming one side only leaves the mapper matching no stored key, and the option stops emitting with nothing louder than a log line. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
Both key lists were checked against a hardcoded 94, which only catches an entry the regex already matches: add one it misses and the count stays 94 while the new key goes untested. Count the declarations instead, and compare the two tables as sets, so a stored key with no mapper fails as loudly as a mapper under no stored key. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Xavier Roche <roche@httrack.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Android wrote
Pausefor the random inter-file pause (-%G), where WinHTTrack and WebHTTrack both writePauseFiles. A profile written by one side reached the other two with that setting missing. This takes the majority spelling and reads the old one back through the rename shim that already carriesProxyType,KeepWwwandKeepSlashes, so existing profiles and saved defaults keep their value.This was the fourth and last divergence the three-way key census turned up; the other three landed in #124.