Skip to content

feat: support complete list items in itemSource - #1354

Merged
briantstephan merged 3 commits into
mainfrom
photo-gallery-v2-port
Oct 7, 2026
Merged

briantstephan merged 3 commits into
mainfrom
photo-gallery-v2-port

Conversation

@briantstephan

@briantstephan briantstephan commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Add complete-item selection and $item resolution through existing itemSource options. Clear old mappings when the source changes and automatically map complete items when exactly one mapping matches.

This represents a subset of the changes from #1339, and is necessary to get the Photo Gallery itemSource changes working in standard-library since that uses a 2.x release.

Tested alongside the aforementioned Photo Gallery changes in standard-library's local-editor and confirmed that everything worked as expected.

Comment thread pnpm-lock.yaml Outdated
Comment thread pnpm-lock.yaml Outdated
@coderabbitai

coderabbitai Bot commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 46 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 69bd5799-96e1-4c46-a395-a69432a5673b
📥 Commits

Reviewing files that changed from the base of the PR and between f5153f9 and 636a599.

📒 Files selected for processing (14)
  • packages/visual-editor/src/components/migrations/0083_photo_gallery_item_source.ts
  • packages/visual-editor/src/components/migrations/migrationRegistry.ts
  • packages/visual-editor/src/editor/yextEntityFieldUtils.test.ts
  • packages/visual-editor/src/editor/yextEntityFieldUtils.ts
  • packages/visual-editor/src/fields/EntityFieldSelectorField.test.tsx
  • packages/visual-editor/src/fields/EntityFieldSelectorField.tsx
  • packages/visual-editor/src/fields/YextAutoField.tsx
  • packages/visual-editor/src/fields/fields.test.tsx
  • packages/visual-editor/src/fields/fields.ts
  • packages/visual-editor/src/internal/components/InternalLayoutEditor.tsx
  • packages/visual-editor/src/utils/cardSlots/mappedSource.ts
  • packages/visual-editor/src/utils/itemSource/createItemSource.test.ts
  • packages/visual-editor/src/utils/itemSource/itemSourceResolution.ts
  • packages/visual-editor/src/utils/itemSource/itemSourceTypes.ts
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jwartofsky-yext jwartofsky-yext left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@briantstephan
briantstephan merged commit 2025641 into main Oct 7, 2026
15 checks passed
@briantstephan
briantstephan deleted the photo-gallery-v2-port branch October 7, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants