Repository navigation
feat: add image fill type option to both gallery variants - #1358
Conversation
|
Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information. |
commit: |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. WalkthroughThe gallery and carousel variants now expose an image fill type setting. Shared render props pass its value to image components, defaulting to Priority: ⬇️ Low Change: Feature Merge Risk: ⚪ Minimal · up to The image fill setting is available in both gallery variants and controls image fitting across their render paths. No actionable merge-blocking concern was found in the reviewed change. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
auto-screenshot-update: true
…ditor into gallery-image-fill
auto-screenshot-update: true
Previously, the
Image Fill Typefield was only available for the "Carousel" Photo Gallery variant. In the "Gallery" variant, wide images automatically fill the space allotted for the image, which is bad when the images are brand logos. This makes the field available for both variants.Tested in platform and confirmed the field works as expected.
Feel free to test it here:
https://www.yext.com/s/4520471/yextsites/168735/branches/144075/editor#pageSetIdentifier=01a11d63-4b12-709f-9725-0703f0ba5b02&locale=en&themeId=test-gallery-image-fill&entityId=2036975677