Skip to content

feat: add image fill type option to both gallery variants - #1358

Merged
briantstephan merged 5 commits into
release/1.xfrom
gallery-image-fill
Oct 9, 2026
Merged

briantstephan merged 5 commits into
release/1.xfrom
gallery-image-fill

Conversation

@briantstephan

@briantstephan briantstephan commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Previously, the Image Fill Type field was only available for the "Carousel" Photo Gallery variant. In the "Gallery" variant, wide images automatically fill the space allotted for the image, which is bad when the images are brand logos. This makes the field available for both variants.

Tested in platform and confirmed the field works as expected.
Feel free to test it here:
https://www.yext.com/s/4520471/yextsites/168735/branches/144075/editor#pageSetIdentifier=01a11d63-4b12-709f-9725-0703f0ba5b02&locale=en&themeId=test-gallery-image-fill&entityId=2036975677

@briantstephan briantstephan self-assigned this Oct 8, 2026
@briantstephan briantstephan added the create-dev-release Triggers dev release workflow label Oct 8, 2026
@github-actions

github-actions Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@pkg-pr-new

pkg-pr-new Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

commit: 516685f

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: cd5881f7-6d40-4894-b2a0-8d9b74b011fd

📥 Commits

Reviewing files that changed from the base of the PR and between e4afc37 and 342ec27.


📒 Files selected for processing (1)
  • packages/visual-editor/src/components/pageSections/PhotoGallerySection/PhotoGalleryWrapper.tsx

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.



Walkthrough

The gallery and carousel variants now expose an image fill type setting. Shared render props pass its value to image components, defaulting to fill when unset. Tests cover field visibility and options, image fitting, and link behavior.

Priority: ⬇️ Low

Change: Feature

Merge Risk: ⚪ Minimal · up to 51668

The image fill setting is available in both gallery variants and controls image fitting across their render paths. No actionable merge-blocking concern was found in the reviewed change.

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Description check Passed The description clearly explains that the Image Fill Type field is now available for both Photo Gallery variants and identifies the reason for the change.
Title check Passed The title clearly and concisely summarizes the main change: adding the image fill type option to both gallery variants.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.


✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR


  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@briantstephan
briantstephan marked this pull request as ready for review October 8, 2026 21:29
jwartofsky-yext
jwartofsky-yext previously approved these changes Oct 8, 2026

@jwartofsky-yext jwartofsky-yext left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@briantstephan
briantstephan merged commit 7ab2a65 into release/1.x Oct 9, 2026
18 checks passed
@briantstephan
briantstephan deleted the gallery-image-fill branch October 9, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

create-dev-release Triggers dev release workflow

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants