Skip to content

Fix missing dstPath in Copy Bundle Resources phases #1654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ckitakishi wants to merge 2 commits into
base: master
Choose a base branch
from
+7 −2
Open

Fix missing dstPath in Copy Bundle Resources phases #1654

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d46b249
Write an empty destination path for the bundle copy phase
Ckitakishi Sep 18, 2026
5a4c860
Add changelog entry for #1654
Ckitakishi Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
### Fixed
- Fix `syncedFolder` source paths being relative to the spec directory instead of the project directory when they differ, which caused Xcode to treat the synced folder as empty #1636 @Ckitakishi
- Fix nested target attributes (e.g. `attributes.SystemCapabilities`) being serialized as a stringified Swift `Dictionary` description instead of a proper nested plist dictionary, which also caused non-deterministic key ordering in generated `project.pbxproj` files across runs #1639 @imadaan @sergeyospanov
- Fix generated "Copy Bundle Resources" phases missing `dstPath`, which caused Xcode 27.2 project conversion to fail #1654 @Ckitakishi

### Internal
- Use a dedicated local package in the SPM fixture so generated fixtures don't depend on the checkout directory name, such as when running tests from a git worktree @yonaskolb
Expand Down
2 changes: 2 additions & 0 deletions Sources/XcodeGenKit/PBXProjGenerator.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1221,6 +1221,8 @@ public class PBXProjGenerator {

if !copyBundlesReferences.isEmpty {
let copyBundlesPhase = addObject(PBXCopyFilesBuildPhase(
// Xcode expects the key to be present, even when the path is empty.
dstPath: "",
dstSubfolderSpec: .resources,
name: "Copy Bundle Resources",
files: copyBundlesReferences
Expand Down
1 change: 1 addition & 0 deletions Tests/Fixtures/TestProject/Project.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,6 +616,7 @@
E8BC0F358D693454E5027ECC /* Copy Bundle Resources */ = {
isa = PBXCopyFilesBuildPhase;
buildActionMask = 2147483647;
dstPath = "";
dstSubfolderSpec = 7;
files = (
3BBCA6F76E5F212E9C55FB78 /* BundleX.bundle in Copy Bundle Resources */,
Expand Down
5 changes: 3 additions & 2 deletions Tests/XcodeGenKitTests/ProjectGeneratorTests.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,6 +998,7 @@ class ProjectGeneratorTests: XCTestCase {
let copyBundles = (copyBundlesPhase?.files ?? [])
.compactMap { $0.file?.nameOrPath }
try expect(Set(copyBundles)) == expectedBundlesFiles
try expect(copyBundlesPhase?.dstPath) == ""
}
try expect(copyFilesPhases.count) == expectedCopyFilesPhasesCount
}
Expand Down Expand Up @@ -3724,7 +3725,7 @@ class ProjectGeneratorTests: XCTestCase {

// then
/// XcodeGen ignores embed: false for bundles
try expectCopyPhase(in: pbxProject, withFilePaths: ["bundleA.bundle", "bundleB.bundle"], toSubFolder: .resources)
try expectCopyPhase(in: pbxProject, withFilePaths: ["bundleA.bundle", "bundleB.bundle"], toSubFolder: .resources, dstPath: "")
}

$0.it("ignores custom copy phase spec") {
Expand All @@ -3740,7 +3741,7 @@ class ProjectGeneratorTests: XCTestCase {

// then
/// XcodeGen ignores embed: false for bundles
try expectCopyPhase(in: pbxProject, withFilePaths: ["bundleA.bundle", "bundleB.bundle"], toSubFolder: .resources)
try expectCopyPhase(in: pbxProject, withFilePaths: ["bundleA.bundle", "bundleB.bundle"], toSubFolder: .resources, dstPath: "")
}
}
}
Expand Down
Loading