Alex/monoio runtime#252
Open
Alexei-Kornienko wants to merge 16 commits into
Open
Conversation
Goal of this refactor is to hide Codec and it's implementation details. This opens up a way to easily refactor IO impl to zero-copy variant and support monoio runtime
This allows to remove unnessesary clone operation in fanout scenarios
Try to simplify existing code differences between various runtime/OS variants. Create a separate module for each runtime.
It's more related to how actual IO works depending on the runtime and will have a separate variant for monoio
A lot of changes in traits are caused by the fact that monoio is singlethreaded by default and doesn't require features to be Send
Collaborator
Author
|
One of the things I don't like in this request is changes in FairQueue waker. They are caused by the fact that monoio runtime requires different bound in terms of Send/Sync. I'm looking for a way to reduce the scope of changes related to fair queue |
Member
|
Thanks. Glad we're taking this all on. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this MR is to compare peformance between runtimes and check the ease of adding another runtime.
Additionally it brings several optimizations in the existing socket logic.
Overall it seems quite large and I think If general approach is approved I'll split it into several smaller requests