Repository navigation
Added Support For Pending Storage Group Operations - #2303
Open
vontedduchaithra wants to merge 1 commit into
Open
vontedduchaithra wants to merge 1 commit into
vontedduchaithra wants to merge 1 commit into
Conversation
Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
vontedduchaithra
force-pushed
the
pendingstorage
branch
from
October 13, 2026 09:57
f331069 to
c4e9ef3
Compare
Collaborator
andy-maier
requested changes
Oct 15, 2026
andy-maier
left a comment
Member
There was a problem hiding this comment.
I have two comments
- On the commit message and PR title:
This PR does not "Add Support For Pending Storage Group Operations".
Instead, it:
- adds end2end tests for some functions
- adds mock support for some functions
- adds unit tests for some functions, using that mock support.
Please change the commit message accordingly. It should show the three items above, with details as to what operations are now mocked and what functions are now tested.
- Since the new mock support is also available for users, a change log fragment file of type "feature" should be added that explains what is newly available, plus another one of type "feature" that briefly mentions the additional tests (you don't need to go into the details of which functions are tested as you do in the commit message, just mention the area at a high level (e.g. "Added end2end and unit testcases for FICON storage").
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.