Skip to content

Added Support For Pending Storage Group Operations - #2303

Open
vontedduchaithra wants to merge 1 commit into
masterfrom
pendingstorage
Open

vontedduchaithra wants to merge 1 commit into
masterfrom
pendingstorage

Conversation

@vontedduchaithra

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Vonteddu Chaithra <Vonteddu.Chaithra1@ibm.com>
@coveralls

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 79.809% (-0.005%) from 79.814% — pendingstorage into master

@andy-maier andy-maier left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have two comments

  1. On the commit message and PR title:

This PR does not "Add Support For Pending Storage Group Operations".

Instead, it:

  • adds end2end tests for some functions
  • adds mock support for some functions
  • adds unit tests for some functions, using that mock support.

Please change the commit message accordingly. It should show the three items above, with details as to what operations are now mocked and what functions are now tested.

  1. Since the new mock support is also available for users, a change log fragment file of type "feature" should be added that explains what is newly available, plus another one of type "feature" that briefly mentions the additional tests (you don't need to go into the details of which functions are tested as you do in the commit message, just mention the area at a high level (e.g. "Added end2end and unit testcases for FICON storage").

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants