AstGen: allow unary float builtins to forward a result location - #23988
Merged
Merged
Conversation
Member
|
Just a reminder that, if accepted, this should have some copy-pastable release notes in the PR description. |
Contributor
Author
|
Yeah, happy to write them up. |
mlugg
requested changes
Aug 13, 2025
mlugg
left a comment
Member
There was a problem hiding this comment.
One nitpick. If you fix that and rebase (I see at least one writergate-related change you'll need to make), I'll be happy to merge (ping me if I forget).
Rexicon226
force-pushed
the
float-op-rl
branch
from
August 13, 2025 14:06
963e1f1 to
206a54d
Compare
Rexicon226
force-pushed
the
float-op-rl
branch
from
August 13, 2025 14:22
206a54d to
443720e
Compare
Rexicon226
force-pushed
the
float-op-rl
branch
from
August 13, 2025 15:17
443720e to
02eb72c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Previously Zig would not forward a result-location through the following builtin functions,
This has now been changed. Where previous you couldn't write,
since
@sqrtwould not forward thef64result type to@floatFromInt, now you can.