GPU/TPC: Increace assumed cacheline size to 128 byte in cluster finder#15545
Open
fweig wants to merge 1 commit into
Open
GPU/TPC: Increace assumed cacheline size to 128 byte in cluster finder#15545fweig wants to merge 1 commit into
fweig wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjust memory layout in TPC cluster finder for 128 byte cachelines found in modern GPU architectures.
On RTX 5080 this increases the throughput of the noisy pad filter from 221 GB/s to 379 GB/s.
On Radeon VII throughput increases from 58 GB/s to 81 GB/s.
Other kernels of the cluster finder either slightly increase in performance or stay the same.
In my test this makes the full cluster finder slightly slower on CPU (869ms -> 891ms), but I don't think this is large enough to justify adding a separate path for 64 byte cachelines.