Repository navigation
Stop the sdist guard from failing on a complete sdist - #4
Merged
Merged
Conversation
The release run for v0.2.0 reported "sdist is missing CMakeLists.txt" for an sdist that contained it. `tar tzf archive | grep -q PATTERN` under `set -o pipefail` is the trap: grep -q exits the instant it matches, tar then dies of SIGPIPE writing the rest of the listing, and pipefail reports the pipeline as failed. Exit status 141 on a successful match. List the archive once into a file and grep the file. The guard did its job in the sense that mattered -- publishing was skipped rather than proceeding on an unverified artifact -- but it was checking the wrong thing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.2.0 release run reported "sdist is missing CMakeLists.txt" for an sdist that contained it.
tar tzf archive | grep -q PATTERNunderset -o pipefail: grep -q exits on first match, tar dies of SIGPIPE, pipefail reports failure. Exit 141 on a successful match.Now lists the archive once into a file and greps that. Verified locally: old form exits 141, new form exits 0.