Repository navigation
Regenerate the charts from the run the tables quote - #5
Merged
Merged
Conversation
The release run for v0.2.0 reported "sdist is missing CMakeLists.txt" for an sdist that contained it. `tar tzf archive | grep -q PATTERN` under `set -o pipefail` is the trap: grep -q exits the instant it matches, tar then dies of SIGPIPE writing the rest of the listing, and pipefail reports the pipeline as failed. Exit status 141 on a successful match. List the archive once into a file and grep the file. The guard did its job in the sense that mattered -- publishing was skipped rather than proceeding on an unverified artifact -- but it was checking the wrong thing.
…ng one benchmark_speed.png came from a different benchmark run than the tables did, so the chart said 33x at n=20,000 where the README said 30x. Both figures are now regenerated from the same results file the re-baselined numbers came from, and they agree: 63, 38, 32, 33, 30, 29, 20, 12. benchmark_dimensions.png was generated by benchmarks/figures.py and referenced from nowhere, which is both why nobody noticed it had gone stale and why it was 75 KB of dead weight. It illustrates precisely the claim the implementation notes make -- that scikit-learn's baseline is not monotonic in d, because it switches between KD-tree and brute force around d = 8 -- so it is now shown there. Every image in img/ is now referenced by something.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmark_speed.pngcame from a different run than the tables, so the chart said 33x at n=20,000 where the README said 30x. Both perf figures are now regenerated from the same results file the re-baselined numbers came from.benchmark_dimensions.pngwas referenced from nowhere — which is why it went stale unnoticed. It illustrates exactly the claim the implementation notes make (scikit-learn is not monotonic in d because it switches between KD-tree and brute force), so it is shown there now. Every image inimg/is referenced.