Repository navigation
fix(php): installation for Ubuntu Resolute - #548
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the PHP Dev Container feature to better handle newer Ubuntu releases by adjusting how PHP apt sources are configured (including a special-case for the Ubuntu resolute codename), and bumps the feature version accordingly.
Changes:
- Add Ubuntu
resolutehandling to use the Sury PHP repository/keyring rather than the Ondřej Surý PPA. - Clean up
casestatement terminators (;;) and minor shell redirection formatting. - Bump feature version from
2.10.0to2.10.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| features/src/php/install.sh | Adjusts apt repository/key handling for Ubuntu resolute, plus minor shell fixes/cleanup. |
| features/src/php/devcontainer-feature.json | Bumps feature version to reflect the installation logic update. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the PHP Dev Container feature to improve compatibility with the latest Ubuntu releases and refines the package installation process. The main changes involve handling the new Ubuntu "resolute" codename and updating the version number.
Ubuntu compatibility improvements:
features/src/php/install.sh: Added logic to detect if the Ubuntu codename is "resolute" and, if so, use the Sury PHP repository and its keyring instead of the Ondřej Surý PPA, ensuring PHP can be installed on newer Ubuntu versions.Versioning and maintenance:
features/src/php/devcontainer-feature.json: Bumped the feature version from2.10.0to2.10.1to reflect these updates.features/src/php/install.sh: Cleaned up the case statement by adding missing;;to properly terminate unsupported distribution handling.