Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the vip-cli devcontainer feature installation to ensure Node.js tooling is present, and bumps the feature version to reflect the change.
Changes:
- Adjusts the Debian install path to install Node.js (and attempts to ensure
npmavailability). - Normalizes
hash ... >/dev/nullredirections in thevip-cliinstall script. - Bumps
vip-clifeature version from1.5.0to1.5.1.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
features/src/vip-cli/install.sh |
Updates Node.js/npm installation logic for Debian/Alpine and related command checks. |
features/src/vip-cli/devcontainer-feature.json |
Bumps feature version to 1.5.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
|
Related: nodesource/distributions#1946 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request makes a minor update to the VIP-CLI devcontainer feature, primarily addressing a dependency installation issue for Node.js. The most important change is ensuring that both
nodejsandnpmare installed in the development environment.Dependency installation fix:
features/src/vip-cli/install.sh) to install bothnodejsandnpminstead of justnodejs, ensuring that the Node.js package manager is available in the dev environment.Version bump:
features/src/vip-cli/devcontainer-feature.jsonfrom1.5.0to1.5.1to reflect the change.