Skip to content

fix(vip-cli): install npm explicitly #554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sjinks wants to merge 1 commit into from
Closed

fix(vip-cli): install npm explicitly #554

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion features/src/vip-cli/devcontainer-feature.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"id": "vip-cli",
"name": "VIP-CLI",
"version": "1.5.0",
"version": "1.5.1",
"description": "Installs VIP-CLI into the Dev Environment",
"options": {
"enabled": {
Expand Down
18 changes: 9 additions & 9 deletions features/src/vip-cli/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ if [ "${ENABLED}" = "true" ]; then
install -d -D -m 0755 /usr/local/etc/vscode-dev-containers/vip-codespaces/vip-cli
install -m 0644 devcontainer-feature.json devcontainer-features.env /usr/local/etc/vscode-dev-containers/vip-codespaces/vip-cli/

if ! hash node >/dev/null 2>&1 || ! hash npm >/dev/null 2>&1; then
if ! hash node > /dev/null 2>&1 || ! hash npm > /dev/null 2>&1; then
# shellcheck source=/dev/null
. /etc/os-release

Expand All @@ -29,13 +29,13 @@ if [ "${ENABLED}" = "true" ]; then
"debian")
export DEBIAN_FRONTEND=noninteractive

if ! hash node >/dev/null 2>&1 || ! hash npm >/dev/null 2>&1 || ! hash npx >/dev/null 2>&1; then
if ! hash node > /dev/null 2>&1 || ! hash npm > /dev/null 2>&1 || ! hash npx > /dev/null 2>&1; then
Comment thread
sjinks marked this conversation as resolved.
PACKAGES=""
if ! hash curl >/dev/null 2>&1; then
if ! hash curl > /dev/null 2>&1; then
PACKAGES="${PACKAGES} curl"
fi

if ! hash update-ca-certificates >/dev/null 2>&1; then
if ! hash update-ca-certificates > /dev/null 2>&1; then
PACKAGES="${PACKAGES} ca-certificates"
fi

Expand All @@ -48,23 +48,23 @@ if [ "${ENABLED}" = "true" ]; then
curl -fsSL https://deb.nodesource.com/setup_lts.x -o nodesource_setup.sh
chmod +x nodesource_setup.sh
./nodesource_setup.sh
apt-get install -y nodejs
apt-get install -y nodejs npm

Comment thread
sjinks marked this conversation as resolved.
apt-get clean
rm -rf /var/lib/apt/lists/*
fi
;;
;;

"alpine")
if ! hash node >/dev/null 2>&1 || ! hash npm >/dev/null 2>&1; then
if ! hash node > /dev/null 2>&1 || ! hash npm > /dev/null 2>&1; then
apk add --no-cache nodejs npm
fi
;;
;;

*)
echo "(!) Unsupported distribution: ${ID}"
exit 1
;;
;;
esac
fi

Expand Down
Loading