Repository navigation
Conversation
Pins labs to aztec-node ea00f1b0 (v6.0.0-rc.4) and drops both queued patches, which aztec-node carries since aztec-labs-eng/aztec-node#524: the testnet compatibility test pinned to the v6 payload VK tree root, and the batch verifier bench taking its VK from the protocol artifacts.
fcarreiro
enabled auto-merge (squash)
October 21, 2026 12:25
IlyasRidhuan
approved these changes
Oct 21, 2026
fcarreiro
marked this pull request as draft
October 21, 2026 15:00
auto-merge was automatically disabled
October 21, 2026 15:00
Pull request was converted to draft
Contributor
Author
|
Superseded by #25677 |
fcarreiro
added a commit
that referenced
this pull request
Oct 21, 2026
Combines #25673 and #25674 on `v6`, plus one commit that drops labs patch `0003`: - `a6d3060919`, `bf8aac88e5` (#25673): `labs` pinned to aztec-node `ea00f1b0` (`v6.0.0-rc.4`), labs patch queue drained, labs' mainnet compatibility test run. - `b89b782a5e` (#25674): Foundry 1.8.5 with bytecode-identical L1 builds, cherry-picked with the same diff. - `e6d3ed1248`: drops `0003-fix-ethereum-default-viem-polling-to-1-s-and-let-tes.patch`. It does not apply to `ea00f1b0`, which already polls anvil test chains every 100 ms in `createExtendedL1Client` (aztec-labs-eng/aztec-node#401). The labs patch series is empty, as on #25673. `ea00f1b0` targets Foundry 1.8.5 and contains aztec-labs-eng/aztec-node#483, the fix for the `l1_fee_analyzer.test.ts` failure #25674 hits on the old pin: block timestamps under anvil 1.8 are whole seconds, so `timeBeforeBlockMs` is negative for a block mined in the snapshot's second.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
labsto aztec-nodeea00f1b0, the commit taggedv6.0.0-rc.4, and drains the labs patch queue onv6.Both queued patches are already in aztec-node at that commit, landed by aztec-labs-eng/aztec-node#524; each reverse-applies cleanly to
ea00f1b0:0001test: pin testnet compatibility to the v6 payload VK tree root0002fix(ivc-integration): take the batch verifier bench VK from the protocol artifactsThe old pin
1b6de149is an ancestor ofea00f1b0.Also drops labs'
mainnet_compatibility.test.tsfromlabs-patches/test_cmd_skip, so the labs test commands collected here run it, and removes the matching note inscripts/labs_env.sh.Part of A-2435.