Repository navigation
chore: bump Foundry to 1.8.5 and labs to v6.0.0-rc.4 on v6 - #25677
Merged
Merged
Conversation
fcarreiro
marked this pull request as ready for review
October 21, 2026 16:00
fcarreiro
requested review from
charlielye,
iAmMichaelConnor,
iakovenkos,
just-mitch,
koenmtb1 and
ludamad
as code owners
October 21, 2026 16:00
Pins labs to aztec-node ea00f1b0 (v6.0.0-rc.4) and drops both queued patches, which aztec-node carries since aztec-labs-eng/aztec-node#524: the testnet compatibility test pinned to the v6 payload VK tree root, and the batch verifier bench taking its VK from the protocol artifacts.
The labs pin ea00f1b0 targets Foundry 1.8.5 itself and polls anvil test chains every 100 ms in createExtendedL1Client (aztec-node #401). The patch does not apply to that pin: its client.ts and env_var.ts hunks conflict with the same code. The labs tests run as they do on aztec-node main.
fcarreiro
force-pushed
the
fc/v6-foundry-1.8.5-labs-rc4
branch
from
October 21, 2026 16:00
c29eabd to
e6d3ed1
Compare
fcarreiro
enabled auto-merge
October 21, 2026 16:01
Collaborator
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This was referenced Oct 21, 2026
alexghr
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combines #25673 and #25674 on
v6, plus one commit that drops labs patch0003:a6d3060919,bf8aac88e5(chore: bump labs to aztec-node ea00f1b0 and drain the labs patch queue #25673):labspinned to aztec-nodeea00f1b0(v6.0.0-rc.4), labs patch queue drained, labs' mainnet compatibility test run.b89b782a5e(chore: bump Foundry to 1.8.5 on v6 with bytecode-identical L1 builds #25674): Foundry 1.8.5 with bytecode-identical L1 builds, cherry-picked with the same diff.e6d3ed1248: drops0003-fix-ethereum-default-viem-polling-to-1-s-and-let-tes.patch. It does not apply toea00f1b0, which already polls anvil test chains every 100 ms increateExtendedL1Client(fix: update Sepolia L1 deployments for Glamsterdam aztec-labs-eng/aztec-node#401). The labs patch series is empty, as on chore: bump labs to aztec-node ea00f1b0 and drain the labs patch queue #25673.ea00f1b0targets Foundry 1.8.5 and contains aztec-labs-eng/aztec-node#483, the fix for thel1_fee_analyzer.test.tsfailure #25674 hits on the old pin: block timestamps under anvil 1.8 are whole seconds, sotimeBeforeBlockMsis negative for a block mined in the snapshot's second.