Skip to content

Add VotingPlugin Control management and inspection support - #1592

Merged
BenCodez merged 7 commits into
masterfrom
codex/reliable-control-file-reads
Aug 31, 2026
Merged

Add VotingPlugin Control management and inspection support#1592
BenCodez merged 7 commits into
masterfrom
codex/reliable-control-file-reads

Conversation

@BenCodez

@BenCodez BenCodez commented Aug 30, 2026

Copy link
Copy Markdown
Owner

Summary

  • Keep Control configuration reads resilient to transient replacement/parsing windows while preserving request-validation failures.
  • Add narrow, typed setup presets for AutoCreateVoteSites and VoteLog settings without exposing or rewriting database credentials.
  • Separate deliberate/manual VoteSite creation from inbound automatic generation, so disabling auto-generation does not block setup tools.
  • Add a real typed reward builder and side-effect-free simulator for site, every-site, and vote-party rewards.
  • Add negotiated data.inspect.v1 support on a dedicated daemon worker for overview, exact-player data, vote-site health, VoteLog summary/search, correlation traces, non-creating service resolution, reward simulation, and redacted diagnostics.
  • Add strict bounds, query timeouts, canonical UUID and ServiceSite validation, result/journal redaction, and protocol-stall regressions.
  • Add AGENTS.md and docs/control-agent-contract.md as compact source-of-truth documentation for maintainers and AI agents.

Operational behavior

  • Changing VoteLog enablement/settings through Control requires a full backend restart. A newly enabled node reports logging as configured but unavailable until its adapter is initialized after restart; a disabled node stops exposing a stale adapter immediately.
  • Vote traces show correlated events present in VotingPlugin's VoteLog. They are not a complete transport-hop or per-command delivery audit.
  • With AutoCreateVoteSites: false, inbound unknown services are still recorded for the detected-service inbox, while automatic creation is skipped and deliberate admin/Control creation remains available.

Safety and compatibility

  • data.inspect.v1 is optional and separately negotiated; existing Control versions ignore it safely.
  • There is no raw SQL, arbitrary command/path, credential, or player-enumeration API.
  • Database work is isolated from heartbeats/configuration polling and uses bounded rows, lookback windows, response sizes, and JDBC query timeouts.
  • Failure messages, change summaries, quick-read values, reward proposals, and persisted recovery results are bounded before submission so malformed or legacy data cannot wedge the operation queue.

Validation

  • Full suite: mvn -B ... test — 489 tests passed
  • Focused Control/configuration suite — 76 tests passed
  • git diff --check
  • Preserved CRLF line endings in the three pre-existing CRLF Java sources

Packaging could not download the uncached maven-jar-plugin:3.5.0 from Maven Central in this restricted runner; compilation and the complete test suite passed.

Paired implementation

Control UI/coordinator: BenCodez/VotingPlugin-Control#10. Merge/deploy this VotingPlugin PR first so the optional capability is available when the new Control UI is rolled out.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for security reviews. Please try again later.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Aug 30, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-08-30T17:20:14.317087Z 4fa1f2b Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4f249d6cca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: eab6cc6da2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez BenCodez changed the title Make Control configuration file reads reliable Add VotingPlugin Control management and inspection support Aug 30, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ef6c3b60cc

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d5349ea130

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1cd5451a4f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 75d8ca86c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

Reviewed commit: 4fa1f2b5b7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@BenCodez
BenCodez merged commit 37f1435 into master Aug 31, 2026
4 checks passed
@BenCodez
BenCodez deleted the codex/reliable-control-file-reads branch August 31, 2026 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant