Skip to content

Upgrade to @labkey/build 10.x - #408

Open
bbimber wants to merge 12 commits into
discvr-26.7from
26.7_fb_webpack_jb
Open

Upgrade to @labkey/build 10.x#408
bbimber wants to merge 12 commits into
discvr-26.7from
26.7_fb_webpack_jb

Conversation

@bbimber

@bbimber bbimber commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

This PR is basically the same as bimberlabinternal/BimberLabKeyModules#231; however, the JBrowse config is a little more involved. Can you please:

  • Make sure this is working and do the same review of jbrowse npm dependencies?
  • JBrowse has custom webpack (now rspack) config files that were added to address some JBrowse-specific issues. I am not sure if these are really needed anymore. My comments in dev_config.js go into detail and have some links. For example, I dont think we need jbrowse-polyfill.
  • I also wonder if we could simplify the jbrowse dependencies. We list a lot of specific packages. We probably should be explicit if our code uses one of them; however, JBrowse does a better job of controlling their exports and we probably wont actually need to depend on all these things. Likewise, I bet JBrowse's package.json has accumulated some dependencies we dont require anymore. node-polyfill is one that's probably not needed, but I didnt test this locally.

@bbimber
bbimber requested a review from hextraza July 24, 2026 20:53
@bbimber
bbimber force-pushed the 26.7_fb_webpack_jb branch from 29255ba to a8f599c Compare July 24, 2026 21:21
@bbimber

bbimber commented Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

NOTE: we should actually delete the JB configs/* files, and also the patch files, assuming we do not need them anymore.

@bbimber

bbimber commented Jul 25, 2026

Copy link
Copy Markdown
Contributor Author

@hextraza, this migration is going to be more complicated. Here is a summary of where I left this:

  • Please see comments at the end of here related to rspack-cli and "--legacy-peer-deps". The latter is causing some problems with JBrowse, I think.
  • I think we can get rid of our custom webpack config files in JBrowse/configs. They are not used here, but not deleted.
  • We need to evaluate the WASM stuff and see if we can get rid of those patches. That code is not called, but also not deleted.
  • We need to actually exercise the JB app, which I have not done yet.
  • I was getting build errors about not being able to find typescript (when npm install was run with --legacy-peer-deps). It would not be hard to depend on it, but I wish there was a clean way to ensure we keep the right version in sync.
  • We may or may not want to explore updating the JB version.
  • We should determine the minimal set of JB-related packages to depend on
  • Newer JB versions require React 19. I am not sure if we can make this switch yet. Should explore.
  • Should determine what options we actually need in tsconfig. I removed some.
  • The changes to ExtendedVcfFeature are a hack to make it build. Should figure out a better option. Maybe there is some kind of @types/xx package?
  • Please see the "_comments" block of package.json. This is the best solution google identified to track notes in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant