Skip to content

Inset liquid faces to fix z-fighting with waterlogged blocks #892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TBlueF merged 1 commit into from
Oct 18, 2026
+8 −0
Merged

Inset liquid faces to fix z-fighting with waterlogged blocks #892

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions core/src/main/java/de/bluecolored/bluemap/core/map/hires/block/LiquidModelRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,7 @@
@SuppressWarnings("DuplicatedCode")
public class LiquidModelRenderer implements BlockRenderer {
private static final float BLOCK_SCALE = 1f / 16f;
private static final float FACE_INSET = 0.016f; // 0.001 blocks
private static final MatrixM3f FLOWING_UV_SCALE = new MatrixM3f()
.identity()
.translate(-0.5f, -0.5f)
Expand Down Expand Up @@ -280,6 +281,13 @@ private boolean createElementFace(Direction faceDir, VectorM3f c0, VectorM3f c1,
c3.x, c3.y, c3.z
);

// move faces slightly inwards, so they don't z-fight with the faces of waterlogged blocks
blockModel.translate(
faceDirVector.getX() * -FACE_INSET,
faceDirVector.getY() * -FACE_INSET,
faceDirVector.getZ() * -FACE_INSET
);

//UV
uvs[0].set(0, 1);
uvs[1].set(1, 1);
Expand Down
Loading