Skip to content

Added guard against n_sided build call not converging #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmwright wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Added guard against n_sided build call not converging #2106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e05acb
Added guard against n_sided build call not converging
jmwright Oct 2, 2026
c96e8af
Missed a space at the end of one of the string literals
jmwright Oct 2, 2026
3026edf
Expanded test to cover the new raise
jmwright Oct 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cadquery/occ_impl/shapes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3631,6 +3631,13 @@ def makeNSidedSurface(
# build, fix and return
n_sided.Build()

# Fail clearly if the solver could not converge (otherwise StdFail_NotDone is issued)
if not n_sided.IsDone():
raise ValueError(
"makeNSidedSurface: The filling algorithm failed to converge. "
"Try a larger nbPtsOnCur or degree, or a looser tol3d"
)

face = n_sided.Shape()

return Face(face).fix()
Expand Down
4 changes: 4 additions & 0 deletions tests/test_cadquery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5746,6 +5746,10 @@ def test_makeNSidedSurface(self):
with raises(ValueError):
Face.makeNSidedSurface(outer_w, [[0, 0, 1]])

# empty boundary so that filler reports not-done
with raises(ValueError):
Face.makeNSidedSurface([], [])

def test_toVtk(self):

from vtkmodules.vtkCommonDataModel import vtkPolyData
Expand Down
Loading