feat(proto): profile CRUD and apply-to-node; ListProfiles returns CertificateProfile#60
Merged
Merged
Conversation
…tificateProfile ListProfilesResponse now carries repeated cryptos.v1.CertificateProfile, the same shape a node stores in pki.profiles[], so the catalog is a lossless superset the node accepts verbatim and drift is a proto compare. Add CreateProfile, UpdateProfile, DeleteProfile, and ApplyProfileToNode with their request/response messages, and remove the parallel fleet.CertProfile message. Regenerate the Go and TypeScript stubs. Closes #59
This was referenced Jul 20, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Turns the read-only seeded profile catalog into a fleet-managed one. The manager catalog reuses the node's own
cryptos.v1.CertificateProfiletype (already imported into fleet.proto for the S5 MachineConfig), so catalog entries and a node'spki.profiles[]become the same type: drift is a proto compare, apply is a verbatim insert.ListProfilesResponsenow returnsrepeated cryptos.v1.CertificateProfile.CreateProfile,UpdateProfile,DeleteProfile, andApplyProfileToNodeRPCs with request/response messages.fleet.CertProfilemessage (never shipped).This is a breaking change only against the unreleased
ListProfiles; nothing has shipped (v1.0.0 not cut).Closes #59
Part of #24
Verification
task lint)task test)go build ./...)How this was verified
task fmt,task lint(buf lint + format check) clean;task generatereproducing the stubs deterministically;go build ./...andtask testgreen; confirmed no strayCertProfilereferences remain.