Apply the global template gate to the add-from-template listing - #15781
Open
svader0 wants to merge 1 commit into
Open
Apply the global template gate to the add-from-template listing#15781svader0 wants to merge 1 commit into
svader0 wants to merge 1 commit into
Conversation
The listing renders finding-template content, which is a shared cross-product store, but its only authorization was view access to the object named in the URL. The sibling routes that read the same store already require the global permission. The check goes in the view body rather than the route permission map so it applies the same way on every edition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hardening / consistency improvement to finding-template authorization. Adds an additional authorization check on one template listing view, plus a regression test in the existing template authorization suite.
No functional change for users who already hold the global template permission. The check is placed in the view body rather than the route permission map so it applies the same way on every edition.