Skip to content

Apply the global template gate to the add-from-template listing #15781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
svader0 wants to merge 1 commit into
base: bugfix
Choose a base branch
from
+17 −0
Open

Apply the global template gate to the add-from-template listing #15781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions dojo/test/ui/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,8 @@ def add_finding_from_template(request, tid, fid):

def search(request, tid):
test = get_object_or_404(Test, id=tid)
# This listing returns template content, a shared cross-product store
user_has_global_permission_or_403(request.user, "edit")
templates = Finding_Template.objects.all()
templates = TemplateFindingFilter(request.GET, queryset=templates)
paged_templates = get_page_items(request, templates.qs, 25)
Expand Down
15 changes: 15 additions & 0 deletions unittests/test_apply_finding_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,3 +690,18 @@ def test_staff_with_global_edit_still_reads_template(self):
with impersonate(staff):
result = views.choose_finding_template_options(request, tid=self.template.id, fid=self.own_finding.id)
self.assertEqual(200, result.status_code)

def test_search_listing_denied(self):
request = FindingTemplateTestUtil.create_get_request(
self.attacker, f"/test/{self.test_a.id}/search")
with impersonate(self.attacker), self.assertRaises(PermissionDenied):
test_views.search(request, tid=self.test_a.id)

def test_search_listing_allows_global_edit(self):
staff = FindingTemplateTestUtil.create_user(is_staff=True)
request = FindingTemplateTestUtil.create_get_request(
staff, f"/test/{self.test_a.id}/search")
with impersonate(staff):
result = test_views.search(request, tid=self.test_a.id)
self.assertEqual(200, result.status_code)
self.assertIn(self.SECRET, result.content.decode())
Loading