Repository navigation
fix(packaging): resolve bare ICU install names beside the source dylib - #383
Merged
Merged
Conversation
Release run 48 failed with "ENOENT: lstat packaging/electron/libicuuc.77.dylib". Postgres.app's ICU libraries record bare install names (libicuuc.77.dylib), and the relinker passed them to realpathSync, which resolved them against the build step's working directory. Resolve a non-absolute dependency next to the image that records it, and fail with a clear message if it is not there.
EraPartner
enabled auto-merge (squash)
October 28, 2026 17:53
Coverage Report for backend
File CoverageNo changed files found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release run 48 (v2.0.0) failed in the mac build with
ENOENT: no such file or directory, lstat '/Users/runner/work/Vision/Vision/packaging/electron/libicuuc.77.dylib'.The cause, inferred from the log: Postgres.app 2.9.6's ICU libraries record bare install names such as
libicuuc.77.dylib.relinkDistributioninpackaging/electron/scripts/prepare-postgres-runtime.tspassed those names tofs.realpathSync, which resolved them against the build step's working directory (packaging/electron).The fix:
Testing
bun run typecheck:electron, eslint and prettier pass on the file.bun test packaging/electron/scripts/prepare-postgres-runtime.test.ts: 4 pass.Generated by Claude Code