Repository navigation
Accept only the same minor version of DOLFINx and UFCxPython in CMake - #4661
Merged
Merged
Conversation
AnyNewerVersion lets find_package(DOLFINX 0.12) accept DOLFINx 0.13, whose SOVERSION is ABI-incompatible. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JudYk8UecTQyirGsLsHUN2
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JudYk8UecTQyirGsLsHUN2
jhale
changed the title
jhale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DOLFINXConfigVersion.cmakeusedCOMPATIBILITY AnyNewerVersion, so a downstreamfind_package(DOLFINX 0.12)accepts DOLFINx 0.13. TheSOVERSIONismajor.minor, so a new minor is ABI-incompatible.SameMinorVersionmakes CMake match. FEniCS/basix#1103 and FEniCS/ffcx#922 make the same change in Basix and ufcx.#2358 switched from
ExactVersiontoAnyNewerVersionbecauseSameMinorVersiondidn't support version ranges. That was true in CMake 3.19, which used only the lower endpoint. Since CMake 3.21 it supports them, and the minimum here is 3.26. I checked with CMake 4.4: requests for0.12and0.12...<0.13both accept0.12.0.0,0.12.0and0.12.1, and both reject0.13.0.FindUFCxPythonis a find module, sofind_package_handle_standard_argsaccepts any newer FFCx forfind_package(UFCxPython 0.12). It already declaresHANDLE_VERSION_RANGE, so the call now requests0.12...<0.13. I ran the module against FFCxmain(0.12.0.dev0). It accepts0.12...<0.13, and rejects0.11...<0.12and0.13...<0.14with "Found unsuitable version". FEniCS/ffcx#922 makes theufcxconfig change.Within this repository nothing requests a DOLFINx version: the demos, tests and Python layer call
find_package(DOLFINX REQUIRED), which still matches any version.🤖 Generated with Claude Code
https://claude.ai/code/session_01JudYk8UecTQyirGsLsHUN2