Repository navigation
Accept only the same minor version in ufcxConfigVersion.cmake - #922
Merged
Merged
Conversation
AnyNewerVersion lets find_package(ufcx 0.12) accept ufcx 0.13, whose ufcx.h interface differs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JudYk8UecTQyirGsLsHUN2
SameMinorVersion supports version ranges from CMake 3.21. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JudYk8UecTQyirGsLsHUN2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ufcxConfigVersion.cmakeusedCOMPATIBILITY AnyNewerVersion, sofind_package(ufcx 0.12)in DOLFINx accepts ufcx 0.13.ufcx.his the interface between generated kernels and DOLFINx and changes between minor versions, so a newer minor is not compatible.SameMinorVersionmatches this, and FEniCS/basix#1103 and FEniCS/dolfinx#4661 make the same change for Basix and DOLFINx.I checked with CMake 4.4: requests for
0.12and0.12...<0.13both accept0.12.0.0,0.12.0and0.12.1, and both reject0.13.0. DOLFINx requests a single version from ufcx, whichSameMinorVersionhas always handled. Range support inSameMinorVersionneeds CMake 3.21, so this also raises the minimum from 3.19 to 3.21.After this, the post-release
mainbumps of FFCx and DOLFINx have to be paired PRs, because DOLFINxmain'sfind_package(ufcx 0.12)stops configuring once ufcx is at 0.13. FEniCS/dolfinx#4660 documents this.🤖 Generated with Claude Code
https://claude.ai/code/session_01JudYk8UecTQyirGsLsHUN2