fix: Break when configured max MBR/EBR partitions are found #83
Merged
Conversation
Previously the code would break from the inner loop but reenter due to the outer while loop in `FF_ParseExtended`. This could result in writing outside of the configured storage area.
2 tasks
archigup
approved these changes
Jun 23, 2026
Member
|
Adding unit testing infra and adding the fix+test should be separate commits |
Member
Author
|
I'm going to merge this in as two commits. 1 for the fix and 1 for the test + infra. I realize the tests one is big but I don't see the point in having a standalone testing infra. In this case the infra is being created because we have introduced a test. I'll fold the formatting changes into their respective commits. |
kstribrnAmzn
force-pushed
the
mbrWriteLimit
branch
from
32f3c8c to
acf19a2
Compare
Member
Author
|
Rebased the formatting changes into the test commit since that was all it touched. Had to force push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously the code would break from the inner loop but reenter
due to the outer while loop in
FF_ParseExtended. This could resultin writing outside of the configured storage area.
Thanks @Eun0us for help in identifying this miss.
Test Steps
Added unit test coverage for modified API. The unit tests are now run during the Github CI workflow.
Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.