Experiment: use a structured finish answer for Stirrup - #496
Closed
ShuxinLin wants to merge 22 commits into
Closed
Conversation
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
…mpt guidelines, and refresh benchmark scenario suites Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Chathurangi Shyalika <chathurangishyalika@Chathurangis-MacBook-Pro.local> Signed-off-by: Chathurangi Shyalika <chathurangijks@gmail.com> Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Signed-off-by: Shuxin Lin <linshuhsin@gmail.com>
Collaborator
Author
|
The custom finish-tool experiment has been fast-forwarded into the parent branch and is now part of #493. Closing this draft as superseded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
finish(reason, paths)contract with an AssetOps-specificfinish(answer, reason, paths)toolfinish.reasonanswer_repairtrajectory persistence and the evaluator's--answer-fieldselection; evaluation now always scoresanswerMotivation
The default Stirrup finish tool only returns a completion
reason, which may be a status summary such as "the task was completed" rather than the response requested by the user. Stirrup 0.1.12 supports custom finish tools, so the response contract can be enforced directly when the agent terminates.With the structured finish contract, a separate repair pass and duplicate trajectory field are unnecessary. Persisted trajectories return to a single source of truth:
{ "answer": "<validated finish answer or legacy final-answer fallback>" }Behavior
finish, preserving Stirrup termination behavior and trajectory compatibilityansweris required and rejects empty or whitespace-only valuesansweris the complete response sent directly to the user and must follow the requested output format without status updates, internal reasoning, or extra commentary unless requestedreasonis optional operational metadata explaining why the run is ending and is not used as the primary responsepathsoptionally lists individual files created or modified for the userfinal_answer()prefersfinish_params.answer, then retains the existing legacy assistant-text andfinish.reasonfallbacksanswer; no repair model call oranswer_repairfield remainsanswerfieldRemoved surface
src/agent/stirrup_agent/answer_repair.pyanswer_repairsupport in trajectory persistenceanswer_fieldconfiguration--answer-fieldoptionTesting
AssetOpsFinishParamsis returnedansweruv run pytest src/agent/stirrup_agent/tests src/observability/tests src/evaluation/tests src/benchmark/tests -q— 188 passeduv run python -m compileall -q src/agent/stirrup_agent src/observability src/evaluationgit diff --checkDependency
This is an experimental stacked PR based on #493. GitHub will show the parent branch changes in this PR until #493 merges into
main; the custom finish experiment begins at commit9515098, and answer repair is removed by commit56e8e37.