Repository navigation
Clearer info text for RSS feed option in news settings of forums and containers - #12088
Merged
thojou merged 3 commits intoOct 28, 2026
Conversation
Chris-Squirrel
added
improvement
translations
Chris-Squirrel
marked this pull request as ready for review
September 18, 2026 10:02
thojou
force-pushed
the
Clearer-news-entries-for-RSS-Feed-links
branch
3 times, most recently
from
October 27, 2026 14:31
d5628c4 to
54dc105
Compare
Contributor
|
Hey @Chris-Squirrel, thanks for the PR. I've changed the logic behind the labels based on context, so the NewsForContextBlockGUI no longer needs an extra database roundtrip to determine the object type. I let the consumer define the respective label. @mjansenDatabay, @alex40724 – I've adjusted the code in your components accordingly. These are just tiny adjustments, so no further review is required. I'll merge this PR tomorrow. Kind regards, |
thojou
approved these changes
Oct 27, 2026
The extra RSS checkbox picked its info text by checking whether the object type is a forum. The caller now passes the language key into `ilNewsForContextBlockGUI::addToSettingsForm`. `ilContainerNewsSettingsGUI` keeps `news_public_feed_info_container` as the default. The forum overrides that key with `news_public_feed_info_frm` before the command is forwarded.
thojou
force-pushed
the
Clearer-news-entries-for-RSS-Feed-links
branch
from
October 28, 2026 10:43
54dc105 to
bbaac5f
Compare
mjansenDatabay
approved these changes
Oct 28, 2026
Contributor
|
Hey @Chris-Squirrel, i adjusted the PR once again and moved the new language variables into their new home. I'm going to merge this now. Kind regards, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the info text for the "Extra RSS Feed" option in the news settings of containers (Categories, Courses, Groups) and Forums.
Problem: I am soon going to create a PR for a general overhaul of the 'news' language entries. The current info text (
news_public_feed_info) needs to be re-written generally. While trying to re-write it, I realised that I would have to leave it frustratingly vague because it is used in Media Casts, Courses, Groups, Containers and Forums... and the Feed link is found in areas that are named differently in each.Solution: Two new language variables with clearer wording that references the block where the feed URL appears:
news_public_feed_info_container— for categories, courses and groups (references the "News" block)news_public_feed_info_frm— for forums (references the "Latest Posts" block, since the news block is renamed in forums viailObjForumGUI::setColumnSettings())The original
news_public_feed_inforemains unchanged for MediaCast settings and the legacy block settings form, although I will be clearing up this entry in the upcoming 'news' overhaulCode change: In
ilNewsForContextBlockGUI::addToSettingsForm(), a small condition selects the appropriate variable based on object type (forum vs. other containers). I obviously had writing these four lines of code - from Mistral AI.