Repository navigation
Conversation
AccountClosurePersistenceIntegrationTest inserted legal holds without applied_at, so the column took the database clock, then released them at fixed instants derived from REQUESTED (2026-08-03). Once the wall clock passed 2026-10-02 the release violated account_legal_hold_release_after_apply (released_at >= applied_at), so two tests have failed on every run since: - activeHeldAccountDoesNotStarveLaterActionableAccountAndReleaseRequeuesIt - retentionHonorsExactIdentifierBoundaryAndLegalHoldBeforeAtomicRelease Both holds now carry an explicit applied_at on the test's own timeline. Production queries read only the hold status, so no runtime code changes. Verified: the class passes 17/17 with the fix and still fails 2/17 without it; the full suite passes (1054 tests, 0 failures, 1 opt-in skip). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #294.