fix(player): fix Android 17 lockscreen playback and SABR seek buffering#70
Open
Priveetee wants to merge 1 commit into
Open
fix(player): fix Android 17 lockscreen playback and SABR seek buffering#70Priveetee wants to merge 1 commit into
Priveetee wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes InfinityLoop1308/PipePipe#2575
Pairs with the extractor-side SABR cold-start fix: InfinityLoop1308/PipePipeExtractor#80
Summary
I reproduced the lockscreen/background issue on my Pixel 8 / Android 17.
There were two problems here:
Problem
After
startForeground(), later notification updates could go throughnotify()instead of keeping the service foreground notification updated throughstartForeground().For SABR, lockscreen seek can call
seekToUs()without a new track selection. That means ExoPlayer starts asking for the new segment, but SABR was still pacing from the previous reader position.Observed during repro:
Changes
startForeground()while the player service is alive.SabrMediaPeriod.seekToUs(), not only from track selection.Validation
Tested on Pixel 8 / Android 17:
Build:
./gradlew :app:assembleDebuggit diff --check